Marketers Delight 5.3.2 Maintenance Release and Drop-in Enhancements

Alex

MD developer
Staff member
Md
XFtoWP
Messages
6,283
Reaction score
1,705
Should I go for Dark Color mode, @Alex ? What do you think?
For a site like yours with as many long-form articles, absolutely! But for the same reason, I think it is more important to keep a light mode and not go either-or.

If only there were an MD dark mode to help with this. :whistle:
 
Comment

Alex

MD developer
Staff member
Md
XFtoWP
Messages
6,283
Reaction score
1,705
Only if you used CSS variables in the stylesheets. ;)
Sure we do. Here's what the body selector looks like in a dynamic CSS file:

PHP:
body {
    background-color: <?php echo $colors['site']['bg_color']; ?>;
    color: <?php echo $colors['site']['text']; ?>;
    font-size: <?php echo $typography['body']['font_size']['desktop']; ?>px;
    font-family: <?php echo $typography['body']['font_family']; ?>;
    font-weight: <?php echo $font_weight; ?>;
    line-height: <?php echo $typography['body']['line_height']['desktop']; ?>px;
    position: relative;
}

Of course, I know you are referring to CSS variables and that is something our dynamic stylesheets could easily plug into, which I am open to for MD's dark mode support.
 
Comment

gauravtiwari

Blogger
Md
Messages
236
Reaction score
104
Website
gauravtiwari.org
Editor Dark Mode1637756589993.png
 
2 Comments
Alex
Alex commented
Nice! MD5.3.2 made some enhancements here to ensure dark background and light text combinations always render properly in the Block editor.
 
gauravtiwari
gauravtiwari commented
Ohh! I am using prefers-color-scheme in editor-styles CSS so that it has dark text on a light background in light mode and light text on a dark background in dark mode.
 

Alex

MD developer
Staff member
Md
XFtoWP
Messages
6,283
Reaction score
1,705
@gauravtiwari it will be best to post feature requests to the proper forum so we can better track and vote on them as this thread is primarily about the MD5.3.2 release.
 
Comment
Top